While reading a recent article in MSDN magazine, I came across some code that gives me a great opportunity to show how to get more done with less effort by using LINQ.

Here’s the code I found, showing how to build three parallel arrays from a List<BugInfo>:

DateTime[] dates = new DateTime[bugInfoList.Count];
int[] numberOpen = new int[bugInfoList.Count];
int[] numberClosed = new int[bugInfoList.Count];
for (int i = 0; i < bugInfoList.Count; ++i)
{
    dates[i] = bugInfoList[i].date;
    numberOpen[i] = bugInfoList[i].numberOpen;
    numberClosed[i] = bugInfoList[i].numberClosed;
}

The first, and obvious, suggestion to make is to use foreach instead of for:

DateTime[] dates = new DateTime[bugInfoList.Count];
int[] numberOpen = new int[bugInfoList.Count];
int[] numberClosed = new int[bugInfoList.Count];
int index = 0;
foreach(var bug in bugInfoList)
{
    dates[i] = bug.date;
    numberOpen[i] = bug.numberOpen;
    numberClosed[i] = bug.numberClosed;
    index++;
}

While this does incur the overhead of maintaining the index independently, this does avoid indexing into the list multiple times, and I’d suggest this code is easier to read.

The second, and less obvious, suggestion is to use LINQ to generate the arrays directly:

DateTime[] dates = bugInfoList.Select(b => b.date).ToArray();
int[] numberOpen = bugInfoList.Select(b => b.numberOpen).ToArray();
int[] numberClosed = bugInfoList.Select(b => b.numberClosed).ToArray();

Shorter still - very short, even - and easy to read. More importantly, many fewer opportunities to get it wrong, introducing a bug.

(Before someone flames me with the obvious: Yes, this is (technically) worse performing because it will iterate the list three times - but I’d suggest the difference isn’t likely to be significant. Micro-optimizations are seldom worth the effort. As always, don’t guess at performance, measure it with a profiler.)

Comments

blog comments powered by Disqus
Next Post
GraphVis Configuration for NAntGraph  30 Jun 2010
Prior Post
Avoiding Stack Overflow with Params  24 Jun 2010
Related Posts
Equality has Symmetry  17 Mar 2018
Type Miscellany  05 Mar 2017
Testing Immutable Types  25 Feb 2017
Factory Methods  18 Feb 2017
Queue Concatenation  11 Feb 2017
Complex Queues  04 Feb 2017
The Problem with the Simple Queue  28 Jan 2017
Enumeration of Queues  21 Jan 2017
Reversing Stacks  14 Jan 2017
Simple Queues  07 Jan 2017
More csharp posts »
Archives
June 2010
2010